#12820: OS X Lion: use "clang" as default C compiler
----------------------------------+-----------------------------------------
Reporter: jdemeyer | Owner: GeorgSWeber
Type: defect | Status: positive_review
Priority: major | Milestone: sage-5.0
Component: build | Resolution:
Keywords: | Work issues:
Report Upstream: N/A | Reviewers: Leif Leonhardy
Authors: Jeroen Demeyer | Merged in:
Dependencies: | Stopgaps:
----------------------------------+-----------------------------------------
Changes (by leif):
* status: needs_review => positive_review
* reviewer: => Leif Leonhardy
Comment:
Replying to [comment:8 jdemeyer]:
> Changed the patch to only set `CC=clang` if `[ "$SAGE_BUILD_TOOLCHAIN" =
yes ]`.
Patch looks ok (and applies to beta13), I just still wonder whether that
shouldn't simply be done in `spkg/install` (where also
`SAGE_BUILD_TOOLCHAIN` is set; it isn't set anywhere else).
Is there any scenario where a script sourcing `sage-env` (or called by one
which does) would need `CC=clang` if `SAGE_BUILD_TOOLCHAIN=yes`, but
'''isn't''' (indirectly) called by `spkg/install` / the "second level"
`make`? (Probably you have some further plans...)
I don't think I'm going to actually test that (on Lion), so rather
"theoretical" positive review. (If someone objects, of course feel free
to revert it.)
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12820#comment:9>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
