#12737: Remove simplify_radical() from simplify_full()
------------------------------------+---------------------------------------
Reporter: mjo | Owner: mjo
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-5.0
Component: symbolics | Resolution:
Keywords: | Work issues:
Report Upstream: N/A | Reviewers:
Authors: Michael Orlitzky | Merged in:
Dependencies: | Stopgaps:
------------------------------------+---------------------------------------
Changes (by {'newvalue': u'Michael Orlitzky', 'oldvalue': ''}):
* status: needs_info => needs_review
* dependencies: #12650 =>
* author: => Michael Orlitzky
Old description:
> Followup to #12650. There are a number of tickets open due to the use of
> `simplify_radical()` in `simplify_full()`. By adding an `unsafe`
> argument, we make sure the user really knows what he's doing.
>
> For example,
>
> {{{
> sage: f = sqrt( (x+1)^2 )
> sage: f.full_simplify(unsafe=True)
> x + 1
> }}}
>
> This will fix at least,
>
> * [http://ask.sagemath.org/question/767/simplification-errors-in-simple-
> expressions Ask Sage 767]
> * #3520 - inconsistency in simplify_radical
> * #11668 - `abs(a+b)^2 == (a+b)^2`
> * #11934 - Symbolic simplification error
> * #12322 - invalid simplification of complex logarithm
>
> And maybe more.
New description:
There are a number of tickets open due to the use of `simplify_radical()`
in `simplify_full()`.
Removing it would fix at least,
* [http://ask.sagemath.org/question/767/simplification-errors-in-simple-
expressions Ask Sage 767]
* #3520 - inconsistency in simplify_radical
* #11668 - `abs(a+b)^2 == (a+b)^2`
* #11934 - Symbolic simplification error
* #12322 - invalid simplification of complex logarithm
And maybe more.
--
Comment:
This should be a more straight-forward proposal. I just removed
`simplify_radical()` from `simplify_full()` and fixed a few doctests
(details in the commit message).
One of the doctest fixes is duplicated in #12780; the doctest is wrong
(missing assumptions) but we're masking that fact at the moment.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12737#comment:7>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
