#12496: Improve doctest coverage for integer_ring.pyx
---------------------------------+------------------------------------------
Reporter: slelievre | Owner: slelievre
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-5.0
Component: documentation | Resolution:
Keywords: Cernay2012 | Work issues:
Report Upstream: N/A | Reviewers: Hugh Thomas
Authors: | Merged in:
Dependencies: | Stopgaps:
---------------------------------+------------------------------------------
Changes (by hthomas):
* status: needs_work => needs_review
* reviewer: => Hugh Thomas
Old description:
> Base ticket #12024: bring doctest coverage to 90%.
New description:
Base ticket #12024: bring doctest coverage to 90%.
----
Apply [attachment:trac_12496-integer_ring-sl.patch] and
[attachment:trac_12496-integer_ring.patch].
--
Comment:
I fixed most of the things I was complained about previously. Like the
original author, I do not understand !__richcmp!__ or !__cinit!__ well
enough to write sensible documentation (or tests) for them.
I am still perplexed about _cmp_ is doing.
It is clear that parameter() is returning 1, but I don't understand what
it means.
Since neither the original author nor I are very experienced, perhaps the
best thing would be if someone else could review both our patches.
(Alternatively, Samuel, if you agree with my patches, I am also willing to
agree to yours, so we can set the ticket to postive review. But I think
it might be better to see if someone else will look at it first.)
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12496#comment:5>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
