#12770: cartesian product of directed graphs
-------------------------------------------+--------------------------------
Reporter: chapoton | Owner: jason, ncohen, rlm
Type: defect | Status: needs_review
Priority: major | Milestone: sage-5.0
Component: graph theory | Resolution:
Keywords: directed graph, product | Work issues:
Report Upstream: N/A | Reviewers: Frédéric Chapoton,
Nicolas M. Thiéry
Authors: David Coudert | Merged in:
Dependencies: | Stopgaps:
-------------------------------------------+--------------------------------
Changes (by nthiery):
* reviewer: Frédéric Chapoton => Frédéric Chapoton, Nicolas M. Thiéry
Comment:
Replying to [comment:15 dcoudert]:
> The point is that using add_edges, we first create a new list of edges,
and then iterate this list to add edges to the new graph.
Actually the code did not create a list: just an iterator over those
edges. But it might well be that using an iterator induces some overhead.
> So somehow we do the job twice. My tests suggest that current
implementation is a bit faster.
A good reason :-)
> I have changed the patch to use the edge_iterator. It is now slightly
faster (few ms less on large graphs).
Thanks! Positive review.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12770#comment:18>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
