#10993: Update eclib to latest upstream release
-----------------------------------+----------------------------------------
Reporter: cremona | Owner: cremona
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-5.0
Component: packages | Resolution:
Keywords: elliptic curves | Work issues: ldconfig in spkg-install
Report Upstream: N/A | Reviewers: Frithjof Schulze, Jeroen
Demeyer
Authors: John Cremona | Merged in:
Dependencies: #11354 | Stopgaps:
-----------------------------------+----------------------------------------
Comment (by leif):
Replying to [comment:97 cremona]:
> Replying to [comment:96 leif]:
> > `spkg-install` and `spkg-check` certainly need some clean-up; I can do
that (or am actually at it).
>
> Obviously so for spkg-install, since I left in commented-out code which
might be needed, but spkg-check could hardly be cleaner?
Well, perhaps not "cleaner", but I did
{{{
#!patch
--- a/spkg-check
+++ b/spkg-check
@@ -1,5 +1,21 @@
#!/usr/bin/env bash
+if [ -z "$SAGE_LOCAL" ]; then
+ echo >&2 "Error: SAGE_LOCAL undefined - exiting..."
+ echo >&2 "Maybe run 'sage -sh'?"
+ exit 1
+fi
+
+# We don't have to set up any environment variables here since the
+# Makefiles already have them from 'configure'. (Hopefully.)
+
cd src
-make check
+echo
+echo "Now running eclib's test suite..."
+$MAKE check
+if [ $? -ne 0 ]; then
+ echo >&2 "Error: eclib's test suite failed to pass."
+ exit 1
+fi
+echo "eclib's test suite passed without errors."
}}}
I.e., use `$MAKE`, add the usual sanity check and some messages.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/10993#comment:99>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
