#12761: Givaro's (3.2.13.rc1) C++ headers don't conform to C++11
--------------------------------------------------------------+-------------
Reporter: leif | Owner:
leif
Type: defect | Status:
needs_review
Priority: major | Milestone:
sage-5.0
Component: packages | Resolution:
Keywords: C++11 GCC 4.7.0 CXXFLAGS -fpermissive spkg | Work issues:
Report Upstream: N/A | Reviewers:
Authors: Leif Leonhardy | Merged in:
Dependencies: | Stopgaps:
--------------------------------------------------------------+-------------
Comment (by leif):
Replying to [comment:9 ddrake]:
> The new spkg actually builds and passes tests (such as they are) on
skynet/cicero. I can give a positive review to everything
Fine.
> except your new header patches; they seem simple enough (almost all of
it is just casting things to other types, right?) but I don't know enough
C++ to be confident about that.
Nope, I haven't added casts, but (roughly speaking) qualified the names of
(mostly, I think) member functions used in ''template'' class member
functions, i.e.,
{{{
#!c++
template <class Foo>
void Bar<Foo>::bar() // member function bar() of class Bar, which is
parameterized by a class Foo
{
Bar<Foo>::baz(); // call with qualified [function] name;
// baz() here is [also] a member function of
[template] class Bar
}
}}}
instead of
{{{
#!c++
...
{
baz(); // call with unqualified [function] name
}
}}}
I could have used
{{{
#!c++
...
{
this->baz();
}
}}}
instead in most (if not all) cases as well; cf. Andrew Ohana's changes at
#12444 (which I unfortunately found only after I made my own changes).
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12761#comment:10>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
