#12857: Split off Graphics class from plot.py
----------------------------------+-----------------------------------------
Reporter: jdemeyer | Owner: tbd
Type: enhancement | Status: needs_review
Priority: blocker | Milestone: sage-5.0
Component: graphics | Resolution:
Keywords: | Work issues:
Report Upstream: N/A | Reviewers: Benjamin Jones, Florent
Hivert
Authors: Jeroen Demeyer | Merged in:
Dependencies: | Stopgaps:
----------------------------------+-----------------------------------------
Changes (by hivert):
* reviewer: Benjamin Jones => Benjamin Jones, Florent Hivert
Old description:
> The file `sage/plot/plot.py` is getting huge. One consequence is that
> doctesting this file (without `--long`) takes double the time of any
> other file. '''blocker''' because it regularly causes doctest timeouts.
>
> The following will be moved to a new file `graphics.py`:
> 1. class `Graphics`
> 2. class `GraphicsArray`
> 3. def `show_default`
> 4. def `is_Graphics`
>
> A few doctests consistently taking at least 2 seconds on `sage.math` have
> been marked `# long time`.
>
> Before this patch on `sage.math`:
> {{{
> sage -t "devel/sage/sage/plot/plot.py"
> [133.6 s]
> }}}
>
> After this patch on `sage.math`:
> {{{
> sage -t "devel/sage/sage/plot/graphics.py"
> [51.5 s]
> sage -t "devel/sage/sage/plot/plot.py"
> [67.9 s]
> }}}
>
> The patch was created by first ''copying'' `plot.py` to `graphics.py` and
> then removing the duplicate code in either `plot.py` or `graphics.py`.
New description:
The file `sage/plot/plot.py` is getting huge. One consequence is that
doctesting this file (without `--long`) takes double the time of any other
file. '''blocker''' because it regularly causes doctest timeouts.
The following will be moved to a new file `graphics.py`:
1. class `Graphics`
2. class `GraphicsArray`
3. def `show_default`
4. def `is_Graphics`
A few doctests consistently taking at least 2 seconds on `sage.math` have
been marked `# long time`.
Before this patch on `sage.math`:
{{{
sage -t "devel/sage/sage/plot/plot.py"
[133.6 s]
}}}
After this patch on `sage.math`:
{{{
sage -t "devel/sage/sage/plot/graphics.py"
[51.5 s]
sage -t "devel/sage/sage/plot/plot.py"
[67.9 s]
}}}
The patch was created by first ''copying'' `plot.py` to `graphics.py` and
then
removing the duplicate code in either `plot.py` or `graphics.py`.
'''Apply :'''
- attachment:12857_split_graphics.patch
- attachment:trac_12857-split_graphics_review-fh.patch
--
Comment:
Good news ! No broken links were reported ! So upto doctesting the whole
Sage lib, I'm positive review with the patch. Please review my review
patch.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12857#comment:21>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
