#12857: Split off Graphics class from plot.py
----------------------------------+-----------------------------------------
       Reporter:  jdemeyer        |         Owner:  tbd                         
  
           Type:  enhancement     |        Status:  needs_review                
  
       Priority:  blocker         |     Milestone:  sage-5.0                    
  
      Component:  graphics        |    Resolution:                              
  
       Keywords:                  |   Work issues:                              
  
Report Upstream:  N/A             |     Reviewers:  Benjamin Jones, Florent 
Hivert
        Authors:  Jeroen Demeyer  |     Merged in:                              
  
   Dependencies:                  |      Stopgaps:                              
  
----------------------------------+-----------------------------------------

Comment (by hivert):

 Replying to [comment:23 kcrisman]:
 > Your patch needs to have a useful commit message.

 Oups !

 > Also, after {{{sage: g2.show() }}} you should have a blank, like
 >
 > {{{
 >     sage: g2.show()
 >
 > ::
 >
 >     sage: isinstance(g2, Graphics)
 > }}}
 > so that people can see the graphic.  In this case, an empty one with
 just axes, but it does work.
 >
 > Otherwise this reviewer patch seems ok, modulo that I haven't tested
 whether anything applies - taking your word for it.

 The new uploaded patch should adress you comments.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12857#comment:24>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to