#12877: Categories for padics, schemes, and some more rings
-------------------------------------+--------------------------------------
       Reporter:  nthiery            |         Owner:                 
           Type:  enhancement        |        Status:  positive_review
       Priority:  major              |     Milestone:  sage-5.1       
      Component:  categories         |    Resolution:                 
       Keywords:                     |   Work issues:                 
Report Upstream:  N/A                |     Reviewers:  Simon King     
        Authors:  Nicolas M. ThiƩry  |     Merged in:                 
   Dependencies:                     |      Stopgaps:                 
-------------------------------------+--------------------------------------
Changes (by SimonKing):

  * status:  needs_review => positive_review
  * reviewer:  => Simon King


Comment:

 I see. Keywords such as element_constructor aren't accepted by
 `CommutativeRing.__init__`. So, no reviewer patch.

 I accept your argument about `RLF` not being of extension type. Since the
 doctests pass and the patch looks fine, I give it a positive review.

 However, I'd like to understand how Parent differs from other classes with
 a custom `__getattr__`.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12877#comment:10>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to