#12876: Fix element and parent classes of Hom categories to be abstract, and
simplify the Hom logic.
--------------------------------------------------------+-------------------
Reporter: nthiery | Owner:
nthiery
Type: enhancement | Status:
needs_work
Priority: major | Milestone:
sage-5.1
Component: categories | Resolution:
Keywords: categories, Hom | Work issues: Fix
the review-nt patch, fix doctests in map.pyx and homset.py
Report Upstream: N/A | Reviewers: Simon
King
Authors: Nicolas M. Thiéry | Merged in:
Dependencies: #715, #11521, #12875, #12877, #12215 | Stopgaps:
--------------------------------------------------------+-------------------
Comment (by nthiery):
Replying to [comment:34 SimonKing]:
> [attachment:trac_12876_category-fix_abstract_class-nt-rel11521-review-
nt.patch] doesn't work, because you confused ` with '.
>
> Please change the following hunk:
> {{{
> #!diff
> --- hecke_modules.py
> +++ hecke_modules.py
> @@ -116,7 +116,7 @@ class HeckeModules(Category_module):
> Fixing :meth:`_test_zero` (``__call__`` should accept a
> function as input) and :meth:`_test_elements` (modular
> form morphisms elements should inherit from categories) is
> - :trac:`???`.
> + :trac:`12879`.
>
> TESTS::
> }}}
> since the to-be-changed file has `:trac:'???'`, hence, no backticks
around ???.
Did you include your trac_12876-reviewer.patch (which fixes those
backticks) in between trac_12876_category-fix_abstract_class-nt-
rel11521.patch and trac_12876_category-fix_abstract_class-nt-rel11521
-review-nt.patch?
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12876#comment:36>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
