#12876: Fix element and parent classes of Hom categories to be abstract, and
simplify the Hom logic.
--------------------------------------------------------+-------------------
Reporter: nthiery | Owner:
nthiery
Type: enhancement | Status:
needs_review
Priority: major | Milestone:
sage-5.1
Component: categories | Resolution:
Keywords: categories, Hom | Work issues: Fix
ring_refcount_dict problem
Report Upstream: N/A | Reviewers: Simon
King
Authors: Nicolas M. Thiéry | Merged in:
Dependencies: #715, #11521, #12875, #12877, #12215 | Stopgaps:
--------------------------------------------------------+-------------------
Comment (by nthiery):
Hi Simon!
Replying to [comment:22 SimonKing]:
> With sage-5.0.beta13 plus #715, #11521, #12875, #12877, #12215 and
[attachment:trac_12876_category-fix_abstract_class-nt-rel11521.patch], all
doc tests pass.
Cool!
> In sage/category/hecke_modules.py, you refer to ticket number ??? for
fixing _test_zero and _test_elements. In
sage/schemes/elliptic_curves/ell_curve_isogeny.py, you leave a reference
to trac open as well. Have the tickets now been created? I didn't fix that
yet.
Oops. Those are #12879 and #12880 respectively.
>
> I see that you rename `Rings.HomCategory.ParentMethods.__new__` into
`__new__bx`. Does that mean the ugly `__new__` method ought to be removed
(finally!)?
> But then, shouldn't `__getnewargs__` be removed as well?
Yes, that was my intention indeed: in principle they should not be needed,
and I forgot to remove them. I'll investigate the failure you report on
Monday, unless you beat me to it.
> Please tell whether you want to address these questions in an additional
patch.
Unless removing __getnewargs__ turns out to be hard, I'd rather fix all of
the above right now.
Feel free to experiment: I won't download the patches before Monday.
Thanks a lot for all your quick work on this :-)
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12876#comment:27>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
