#12884: Fix problems introduced by remove_constraint functionality in MIP
----------------------------------------------------------------------------+
Reporter: john_perry |
Owner: ncohen
Type: defect |
Status: needs_review
Priority: minor |
Milestone: sage-5.1
Component: linear programming |
Resolution:
Keywords: glpk, mixed integer programming, mip, linear programming |
Work issues:
Report Upstream: N/A |
Reviewers:
Authors: John Perry |
Merged in:
Dependencies: #12823 |
Stopgaps:
----------------------------------------------------------------------------+
Comment (by john_perry):
Replying to [comment:9 ncohen]:
> > Speaking of which, I noticed that the doctest coverage in
sage/numerical isn't quite at 100%, and some people have been talking
about that. Shall I try to complete that, and add it to this patch?
>
> Oh.. Are we missing much there ? I thought I was careful when writing
the MILP classes `O_o`
You were, actually. We're not missing much; here's the result of what I
get when I run `../../sage -coverage sage/numerical` (slightly edited for
readability)
{{{
No functions in sage/numerical//__init__.py
No functions in sage/numerical//all.py
----------------------------------------------------------------------
sage/numerical//optimize.py
SCORE sage/numerical//optimize.py: 100% (8 of 8)
----------------------------------------------------------------------
----------------------------------------------------------------------
sage/numerical//mip.pyx
ERROR: Please add a `TestSuite(s).run()` doctest.
SCORE sage/numerical//mip.pyx: 98% (59 of 60)
----------------------------------------------------------------------
No functions in sage/numerical//test.py
No functions in sage/numerical//backends/__init__.py
----------------------------------------------------------------------
sage/numerical//backends/gurobi_backend.pyx
ERROR: Please add a `TestSuite(s).run()` doctest.
SCORE sage/numerical//backends/gurobi_backend.pyx: 89% (26 of 29)
----------------------------------------------------------------------
----------------------------------------------------------------------
sage/numerical//backends/generic_backend.pyx
ERROR: Please add a `TestSuite(s).run()` doctest.
SCORE sage/numerical//backends/generic_backend.pyx: 87% (29 of 33)
----------------------------------------------------------------------
----------------------------------------------------------------------
sage/numerical//backends/cplex_backend.pyx
ERROR: Please add a `TestSuite(s).run()` doctest.
SCORE sage/numerical//backends/cplex_backend.pyx: 90% (29 of 32)
----------------------------------------------------------------------
----------------------------------------------------------------------
sage/numerical//backends/coin_backend.pyx
ERROR: Please add a `TestSuite(s).run()` doctest.
SCORE sage/numerical//backends/coin_backend.pyx: 93% (29 of 31)
----------------------------------------------------------------------
----------------------------------------------------------------------
sage/numerical//backends/glpk_backend.pyx
ERROR: Please add a `TestSuite(s).run()` doctest.
SCORE sage/numerical//backends/glpk_backend.pyx: 93% (31 of 33)
----------------------------------------------------------------------
----------------------------------------------------------------------
sage/numerical//knapsack.py
SCORE sage/numerical//knapsack.py: 100% (8 of 8)
----------------------------------------------------------------------
}}}
> I can not check right now as sage 5.0-rc0 is being compiled, but I hope
there is not much work to do. I would also like to see a proud 100% on
these files. If you feel like adding some documentation while working on
this patch please do, but leave some of the work, it would not be fair
otherwise `:-)`
I'll try to take care of it. It's on my schedule for tomorrow, then. :-)
john
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12884#comment:10>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
