#11383: Color('red') == Color('red') returns False
----------------------------------+-----------------------------------------
Reporter: slabbe | Owner: slabbe
Type: defect | Status: needs_review
Priority: major | Milestone: sage-5.0
Component: graphics | Resolution:
Keywords: beginner, sd31 | Work issues:
Report Upstream: N/A | Reviewers:
Authors: Ryan Grout | Merged in:
Dependencies: | Stopgaps:
----------------------------------+-----------------------------------------
Comment (by kcrisman):
I'm a little confused about a few things.
* How many authors do we have, how many reviewers? I'm not going to try
to diff out each of the patches here; can each contributor put their name
where it belongs (maybe both spots sometimes)? For instance, it seems
like aapitzsch acted more in a reviewer role on itaibn's patch.
* {{{sage: Color(0.2,0.3,0.2) == False }}} seems like an odd doctest, but
maybe it's just to check 'garbage' input? {{{sage: Color(0.2,0.3,0.2) ==
0.2}}} or {{{sage: Color(0.2,0.3,0.2) == x^2+1}}} test the same thing, but
make it more obvious that the test isn't a typo and is covering a branch
of the code, like the {{{23}}} comparison in `ne`.
* This is just my preference, but in view of comment:7 it would be nice
to have
{{{
sage: Color((1,0,0)) == Color((1.0,0,0))
True
}}}
although of course the hash issue is taken care of and tested.
* By the way, I get the same hash for `Color('red')` no matter how many
times I do it...
Anyway, none of this is really important enough to hold it up unless one
of the many contributors to the ticket has an idea about them!
Any other things that could be come up here? This is needed for the
eminently more practical #12904 so it would be nice to get positive
review.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11383#comment:17>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
