#11383: Color('red') == Color('red') returns False
----------------------------------+-----------------------------------------
       Reporter:  slabbe          |         Owner:  slabbe      
           Type:  defect          |        Status:  needs_review
       Priority:  major           |     Milestone:  sage-5.0    
      Component:  graphics        |    Resolution:              
       Keywords:  beginner, sd31  |   Work issues:              
Report Upstream:  N/A             |     Reviewers:              
        Authors:  Ryan Grout      |     Merged in:              
   Dependencies:                  |      Stopgaps:              
----------------------------------+-----------------------------------------

Comment (by itaibn):

 Replying to [comment:17 kcrisman]:
 >  * How many authors do we have, how many reviewers?  I'm not going to
 try to diff out each of the patches here; can each contributor put their
 name where it belongs (maybe both spots sometimes)?  For instance, it
 seems like aapitzsch acted more in a reviewer role on itaibn's patch.

 My role was to add the `__ne__` function, improve the `__eq__` function so
 that it doesn't return an error when comparing a `Color` and a
 non-`Color`, and doctest such comparisons (including the
 `Color(0.2,0.3,0.2) == False` test). By looking at the different patches
 it appears as though ryan wrote the `__eq__` function (though the 'v3' in
 the description suggests there's more to it), poeschko wrote the
 `__hash__` function, and aapitzsch improved the line wrapping in my patch
 and improved some unrelated parts of the file.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11383#comment:19>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to