#11919: Issue when pickling a formal function
------------------------------------+---------------------------------------
       Reporter:  cdsousa           |         Owner:  burcin    
           Type:  defect            |        Status:  needs_work
       Priority:  minor             |     Milestone:  sage-5.0  
      Component:  symbolics         |    Resolution:            
       Keywords:  pynac, pickling   |   Work issues:            
Report Upstream:  N/A               |     Reviewers:            
        Authors:  Michael Orlitzky  |     Merged in:            
   Dependencies:                    |      Stopgaps:            
------------------------------------+---------------------------------------
Changes (by burcin):

  * status:  positive_review => needs_work


Comment:

 Replying to [comment:13 nbruin]:
 > Fix confirmed! indeed, the patch simply adds back a line that
 disappeared in #9240 without any reason stated, so probably that was just
 an accident.

 It was not an accident. The python_func flag stored in pynac is not a bool
 any more. It is a bitmask that marks which custom functions are
 implemented in Python. The rest, if they exist are C++ functions.

 > Positive review!

 This patch doesn't fix the problem. It might actually lead to crashes,
 since pynac will look for a python function to call for evaluation,
 differentiation, etc. if some bits in `python_func` are set.

 The correct fix will be to get pynac to create a new dummy symbolic
 function at the point where it raises an error with "unknown function 'f'
 in archive." Relevant code can be found in `ginac/function.{h,cpp}` in
 pynac sources.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11919#comment:15>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to