#11309: Sage sees -x +y > 0, -y + x >= 0, and x -y > 0 as equivalent
-------------------------------------------------------------------+--------
Reporter: tnv |
Owner: burcin
Type: defect |
Status: needs_review
Priority: major |
Milestone: sage-5.0
Component: symbolics |
Resolution:
Keywords: inequality equality relational sd31 __richcmp__ | Work
issues:
Report Upstream: N/A |
Reviewers: Karl-Dieter Crisman, ThanhVu Nguyen
Authors: Keshav Kini, Burcin Erocal | Merged
in:
Dependencies: |
Stopgaps:
-------------------------------------------------------------------+--------
Comment (by kcrisman):
The code itself seems fine right now, thanks for such fast action and
especially for actual comments in the code!
Did you do any timing runs on previously-working comparisons? I agree
that it would be good for someone who knows to comment on whether there is
some obvious optimization missing. For instance, lines 1241ff. would be
nicer if it so happened there was a "operator.opposite()" function which
reversed `<=` and `>=` (though someone else might want them to be
complements, `<=` and `>`). Similarly for the rhs/lhs comparisons.
Keshav, do you mind putting in a test in your patch for
{{{
sage: (x-1<0) in [x-2<0]
False
}}}
just to test for the comment:33 issue? While we wait for someone more
knowledgeable... but as I said it does seem good to go.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11309#comment:40>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
