#12952: DoubleStarSnark, FosterGraph, GrayGraph and HarriesGraph
----------------------------------+-----------------------------------------
Reporter: ncohen | Owner: jason, ncohen, rlm
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-5.1
Component: graph theory | Resolution:
Keywords: | Work issues:
Report Upstream: N/A | Reviewers: Keshav Kini
Authors: Nathann Cohen | Merged in:
Dependencies: #12942, #12945 | Stopgaps:
----------------------------------+-----------------------------------------
Comment (by kini):
Oh, the multiline list syntax? That is something I borrowed from Haskell
style - IMO it is nice for a couple of reasons, 1) there is a visual line
down the left side of the list which clearly shows where it begins and
ends, and 2) adding a new element to the end of the list will only cause a
diff of +1 line, not +2 lines / -1 lines like with the usual Python style.
But I'll get rid of it if you want :)
About the order, I didn't mean about your patch specifically (though your
patch is also not following alphabetic order - D comes after C! :P ) - I
mean the whole file. I mean, why is `HarriesGraph` at the top of the file
but `DoubleStarSnark` is under "Named Graphs"? It seems like the top of
the file was originally for small graphs that are commonly used as
components in other graphs, or something like that, but I guess
`HarriesGraph` probably doesn't have that property, right? Etc. etc.
I think it makes more sense to separate graphs generators into ones that
define families of graphs and one that define single graphs. All four of
the graphs in this patch would fall into the second category.
By the way, [http://www.python.org/dev/peps/pep-0008/#other-
recommendations PEP 8 recommends] putting no spaces around "=" when
defining default arguments in function definitions:
{{{#!python
def f(x, y, z=42):
}}}
not
{{{#!python
def f(x, y, z = 42):
}}}
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12952#comment:11>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
