#12952: DoubleStarSnark, FosterGraph, GrayGraph and HarriesGraph
----------------------------------+-----------------------------------------
Reporter: ncohen | Owner: jason, ncohen, rlm
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-5.1
Component: graph theory | Resolution:
Keywords: | Work issues:
Report Upstream: N/A | Reviewers: Keshav Kini
Authors: Nathann Cohen | Merged in:
Dependencies: #12942, #12945 | Stopgaps:
----------------------------------+-----------------------------------------
Comment (by ncohen):
> About the order, I didn't mean about your patch specifically (though
your patch is also not following alphabetic order - D comes after C! :P )
- I mean the whole file. I mean, why is `HarriesGraph` at the top of the
file but `DoubleStarSnark` is under "Named Graphs"? It seems like the top
of the file was originally for small graphs that are commonly used as
components in other graphs, or something like that, but I guess
`HarriesGraph` probably doesn't have that property, right? Etc. etc.
Oh, right... When I want to add a function I usually do a search thrpugh
the file to find the definition of the previous function, and I add mine
afterwards. But honestly I do not think that not having them sorted really
is a problem. Python sure does not mine and you find the line you are
looking for through a text search, and not by scrolling through the file
sooooo `^^;`
> By the way, [http://www.python.org/dev/peps/pep-0008/#other-
recommendations PEP 8 recommends] putting no spaces around "=" when
defining default arguments in function definitions:
Ahah. Lawyers. Well, on my side I do not mind as long as the code compiles
and is somehow readable, I will try to conform a bit more to this fanciful
"PEP8" when what it says makes some sense, and you are free to change my
code however you like -- you may follow these weird rules but your code is
nice in the end, so why not ? `:-)`
Nathann
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12952#comment:12>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
