#10655: Fix optional animate.py doctests
-------------------------------------------------------------+--------------
       Reporter:  kcrisman                                   |         Owner:  
mvngu                             
           Type:  defect                                     |        Status:  
new                               
       Priority:  minor                                      |     Milestone:   
                                 
      Component:  doctest                                    |    Resolution:   
                                 
       Keywords:  convert ImageMagick animate optional sd31  |   Work issues:   
                                 
Report Upstream:  N/A                                        |     Reviewers:  
John Palmieri, Karl-Dieter Crisman
        Authors:                                             |     Merged in:   
                                 
   Dependencies:                                             |      Stopgaps:   
                                 
-------------------------------------------------------------+--------------
Changes (by kcrisman):

  * reviewer:  => John Palmieri, Karl-Dieter Crisman


Comment:

 Overall it's nearly ready to close.  I think you missed ''one'' of the
 tests.  See [http://hg.sagemath.org/sage-
 main/file/9ab4ab6e12d0/sage/plot/animate.py#l196 this spot in animate.py]
 - I think that line 198 needs the keyword too.

 Yup.
 {{{
 File "/Users/.../sage-5.0/devel/sage-main/sage/plot/animate.py", line 198:
     sage: b.show() # optional
 Exception raised:
     Error: Neither ImageMagick nor ffmpeg appears to be installed. Saving
 an
     animation to a GIF file or displaying an animation requires one of
 these
     packages, so please install one of them and try again.

     See www.imagemagick.org and www.ffmpeg.org for more information.
 **********************************************************************
 }}}
 If I remembered how to test everything optional except a certain keyword,
 it wouldn't have taken so much hunting to find that snippet. Didn't you
 implement that somewhere?  But I couldn't find it in the developer guide
 for 5.0, so it must not have gotten in yet.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/10655#comment:3>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to