#12974: make Graphics class inheritable and some clean ups
-----------------------------------------+----------------------------------
Reporter: ppurka | Owner: jason, was
Type: enhancement | Status: needs_work
Priority: major | Milestone: sage-5.1
Component: graphics | Resolution:
Keywords: | Work issues:
Report Upstream: N/A | Reviewers: Karl-Dieter Crisman
Authors: Punarbasu Purkayastha | Merged in:
Dependencies: | Stopgaps:
-----------------------------------------+----------------------------------
Changes (by {'newvalue': u'Punarbasu Purkayastha', 'oldvalue': ''}):
* status: needs_review => needs_work
* reviewer: => Karl-Dieter Crisman
* author: => Punarbasu Purkayastha
Comment:
In general this looks pretty good, good work on underscores and the
refactor looks ok. The Sage Days 40.5 crowd says "yes!" to making double
underscores single underscores.
* Minor but should be done: get rid of backslashes ending lines.
Suggestion is to just enclose things in parentheses for splitting lines.
* You need to doctest your new matplotlib tick formatter.
* I'm not sure why you alphabetized some of the keywords in various
places. It might make more sense to keep ones together that are related -
e.g., `vgridlinesstyle` and `hgridlinesstyle` should be next to each
other. I don't think this was an optimal change.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12974#comment:2>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
