#12974: make Graphics class inheritable and some clean ups
-----------------------------------------+----------------------------------
Reporter: ppurka | Owner: jason, was
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-5.1
Component: graphics | Resolution:
Keywords: sd40.5 | Work issues:
Report Upstream: N/A | Reviewers: Karl-Dieter Crisman
Authors: Punarbasu Purkayastha | Merged in:
Dependencies: | Stopgaps:
-----------------------------------------+----------------------------------
Comment (by kcrisman):
I like all of this (obviously only did a spot-check of the whitespace file
but it seems fine. I do think that we can't reorder the arguments to the
''function/method'' `matplotlib`, as that would be a change in the API.
The other order changes don't matter because they are dicts or just
initialization, but this one I don't think we can change, even with the
relatively slight possibility that someone actually relies on the keyword
order.
But I think you can still do the same idea of putting the comments for
clarity - I like very much what you did with this overall. Fix the
`matplotlib` thing, and in the meantime I'll run doctests and look at some
of the plots.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12974#comment:6>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
