#12802: test containment of ideals in class MPolynomialIdeal
--------------------------------------------------+-------------------------
       Reporter:  mariah                          |         Owner:  AlexGhitza  
 
           Type:  enhancement                     |        Status:  
needs_review 
       Priority:  minor                           |     Milestone:  sage-5.1    
 
      Component:  algebra                         |    Resolution:              
 
       Keywords:  sd40.5, groebner bases, ideals  |   Work issues:  
documentation
Report Upstream:  N/A                             |     Reviewers:  novoselt    
 
        Authors:  John Perry                      |     Merged in:              
 
   Dependencies:                                  |      Stopgaps:              
 
--------------------------------------------------+-------------------------

Comment (by john_perry):

 To help the reviewer(s), here are the non-whitespace changes.

 1. In `sage/rings/ideal.py`, I added a docstring & doctest to
 `Ideal_generic`'s `__cmp__`.
 1. In `sage/rings/polynomial/multipolynomial_ideal.py`, I
    a. redefined `__cmp__` to rely on `__lt__`, `__gt__`, and `__eq__`;
    a. changed `__eq__` to test whether each ideal is a subset of the
 other;
    a. changed `__gt__` to test whether `other` is a subset of `self`; and
    a. moved the old code for `__eq__` to `__lt__`, where it now checks
 whether each polynomial in the Groebner basis of `self` reduces to 0
 modulo the Groebner basis of `other`. Here, I also had to move a
 `try...except` loop around, because of a strange `AttributeError` related
 to caching, raised '''only''' by the doctests of `pbori.pyx`.

 On my machine all the doctests of `sage/rings` pass with this patch. I
 haven't doctested everything, though.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12802#comment:6>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to