#13073: recognition of weakly chordal graphs
--------------------------------------------------+-------------------------
Reporter: eisermbi | Owner: jason,
ncohen, rlm
Type: enhancement | Status:
needs_review
Priority: major | Milestone: sage-5.1
Component: graph theory | Resolution:
Keywords: weakly chordal, hole, antihole | Work issues:
Report Upstream: N/A | Reviewers:
Authors: | Merged in:
Dependencies: | Stopgaps:
--------------------------------------------------+-------------------------
Comment (by ncohen):
Hellooooo Birk !!
I am currently reviewing your patch. As you code is somewhat long, and
because you convinced me that both functions were useful I thought it
would be better to move the code *out* of graph.py in a new weakly_chordal
module (we already have some modules for specific graph classes). This way
graph.py does not grow too much, and we will be able to add specific
documentation in the module's head. I do it very often these days, and you
can add very interesting things there on what the code actually does.
For instance :
http://www.sagemath.org/doc/reference/sage/graphs/graph_decompositions/rankwidth.html
http://www.sagemath.org/doc/reference/sage/graphs/graph_decompositions/vertex_separation.html
http://www.sagemath.org/doc/reference/sage/graphs/pq_trees.html
This patch is *not* a review. I changed nothing to your code, unless what
I could not avoid:
* The occurrences of ``self`` have been replaced by ``g``
* I changed several instances of "from sage.graphs.all import Graph"
into the more proper "from sage.graphs.graph import Graph"
* The new module is imported in sage.graphs.all.py
* There are shortcuts from graph.py to your methods so that
g.is_long_hole_free still works. And quite honestly we should do this for
many other methods to shorten graph.py !
I will try to send a complete review by today. It will probably take time
as I will have to read/understand the paper to mention. If I can't make
it, you will have it by tomorrow, and unless something really really bad
happens this ticket should be reviewed by the end of the month `:-D`
Nathann
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/13073#comment:4>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
