#12415: Update doctesting framework
-------------------------------------------------------------------------------------------------------------------------+
Reporter: robertwb
| Owner: mvngu
Type: enhancement
| Status: needs_review
Priority: major
| Milestone: sage-5.1
Component: doctest
| Resolution:
Keywords:
| Work issues:
Report Upstream: N/A
| Reviewers: Jeroen Demeyer
Authors: David Roe, Robert Bradshaw
| Merged in:
Dependencies: #13147,#13146, #13145, #12723, #12392, #12393, #12395,
#12396, #12397, #12381, #12382, #12383, #12384 | Stopgaps:
-------------------------------------------------------------------------------------------------------------------------+
Comment (by roed):
Replying to [comment:79 jdemeyer]:
> Replying to [comment:75 roed]:
> > Sure, and for reporting what happened to the user this is fine. But
from the child process' perspective, an unexpected `KeyboardInterrupt` has
been raised and it should stop testing that file.
> Okay, I see what you mean. I would propose not to special-case
`KeyboardInterrupt` at all in the child process. When the parent process
gets a `KeyboardInterrupt`, kill all child processes (without showing
their output) and exit.
>
> (note: since the old doctesting framework didn't do this either, I don't
consider this a prerequisite for positive review, but a nice feature to
have.)
I just tried changing the interrupt handling so that `KeyboardInterrupt`
is handled in the parent process and it doesn't work as well: there's
extraneous printing happening when the doctest framework thinks it's just
printing an unexpected exception, and I don't see a good way to get rid of
it.
I think the current handling of KeyboardInterrupts is fine.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12415#comment:83>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
