#12974: make Graphics class inheritable and some clean ups
-----------------------------------------+----------------------------------
Reporter: ppurka | Owner: jason, was
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-5.2
Component: graphics | Resolution:
Keywords: sd40.5 | Work issues:
Report Upstream: N/A | Reviewers: Karl-Dieter Crisman,
Jeroen Demeyer
Authors: Punarbasu Purkayastha | Merged in:
Dependencies: #12810, #12605 | Stopgaps:
-----------------------------------------+----------------------------------
Changes (by jdemeyer):
* status: needs_work => needs_review
* reviewer: Karl-Dieter Crisman => Karl-Dieter Crisman, Jeroen Demeyer
Old description:
> The first patch makes all the `.__attribute` into `._attribute` so that
> the `Graphics` class can be inherited in the future. This is desirable
> since all the important functions are present in this class. One will not
> lose anything in terms of existing functionality.
>
> The second patch does refactoring of one big bunch of code which is
> present twice in `Graphics().matplotlib()`.
>
> The third and fourth patches are more of a 'cleanup' nature.
>
> Passes all doctests in `devel/sage/sage/plot`. (The patches are created
> using 5.0-rc0)
> ----
> Apply patches in this order to `devel/sage`:
> 1. [attachment:trac_12974-fix_graphics_attributes-rebase.2.patch] - makes
> the change .__ to ._
> 2. [attachment:trac_12974-refactor.patch] - refactoring the tick
> formatter in Graphics.matplotlib
> 3. [attachment:trac_12974-reorder_some_arguments.patch] - does the
> reordering of some arguments
> 4. [attachment:trac_12974-whitespace-rebased.patch] - cleans up trailing
> whitespace via the sed function mentioned in comment:4
New description:
The first patch makes all the `.__attribute` into `._attribute` so that
the `Graphics` class can be inherited in the future. This is desirable
since all the important functions are present in this class. One will not
lose anything in terms of existing functionality.
The second patch does refactoring of one big bunch of code which is
present twice in `Graphics().matplotlib()`.
The third and fourth patches are more of a 'cleanup' nature.
----
'''Apply''' [attachment:12974_flat.patch]
--
Comment:
First three patches put in one big patch, the whitespace patch removed.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12974#comment:21>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
