#12974: make Graphics class inheritable and some clean ups
-----------------------------------------+----------------------------------
       Reporter:  ppurka                 |         Owner:  jason, was           
              
           Type:  enhancement            |        Status:  needs_review         
              
       Priority:  major                  |     Milestone:  sage-5.2             
              
      Component:  graphics               |    Resolution:                       
              
       Keywords:  sd40.5                 |   Work issues:                       
              
Report Upstream:  N/A                    |     Reviewers:  Karl-Dieter Crisman, 
Jeroen Demeyer
        Authors:  Punarbasu Purkayastha  |     Merged in:                       
              
   Dependencies:  #12810, #12605         |      Stopgaps:                       
              
-----------------------------------------+----------------------------------
Changes (by kcrisman):

  * status:  needs_work => needs_review


Old description:

> The first patch makes all the `.__attribute` into `._attribute` so that
> the `Graphics` class can be inherited in the future. This is desirable
> since all the important functions are present in this class. One will not
> lose anything in terms of existing functionality.
>
> The second patch does refactoring of one big bunch of code which is
> present twice in `Graphics().matplotlib()`.
>
> The third and fourth patches are more of a 'cleanup' nature.
>
> ----
>
> '''Apply''' [attachment:12974_flat.patch]

New description:

 The first patch makes all the `.__attribute` into `._attribute` so that
 the `Graphics` class can be inherited in the future. This is desirable
 since all the important functions are present in this class. One will not
 lose anything in terms of existing functionality.

 The second patch does refactoring of one big bunch of code which is
 present twice in `Graphics().matplotlib()`.

 The third and fourth patches are more of a 'cleanup' nature.

 ----
 Since then the patches have been cleaned up themselves in various ways,
 see discussion.

 '''Apply''' [attachment:12974_flat.patch] and
 [attachment:trac_12974-colorfix.patch].

--

Comment:

 Patchbot:

 '''Apply''' [attachment:12974_flat.patch] and
 [attachment:trac_12974-colorfix.patch].

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12974#comment:26>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to