#13192: some code clean up for sage/graphs/graph.py
----------------------------------+-----------------------------------------
Reporter: eisermbi | Owner: jason, ncohen, rlm
Type: defect | Status: needs_info
Priority: major | Milestone: sage-5.2
Component: graph theory | Resolution:
Keywords: sparse6_string | Work issues:
Report Upstream: N/A | Reviewers: Nathann Cohen
Authors: Birk Eisermann | Merged in:
Dependencies: | Stopgaps:
----------------------------------+-----------------------------------------
Comment (by ncohen):
Hmmm... Well. It's true that there are two tests, but that's more or less
just for the show -- or rather because of the "-coverage" Sage flag `:-P`
The thing is that Birk noticed that its documentation was missing some
information, and reading its code we noticed that the function would
behave very badly if used of graphs whose vertices are something different
from integers. We already had some problems of the kind with other codes
that assumed vertices were totally ordered.
Soooooooo as it looks like a custom function, made only to be called by
the function above, and in order to prevent somebody from using it without
knowing that it may be wrong sometimes.... It sounded better to move it
inside of that function.
... And to document its behaviour better, which Birk did `:-)`
What do you think ?
Nathann
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/13192#comment:4>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
