#13192: some code clean up for sage/graphs/graph.py
----------------------------------+-----------------------------------------
       Reporter:  eisermbi        |         Owner:  jason, ncohen, rlm
           Type:  defect          |        Status:  needs_review      
       Priority:  major           |     Milestone:  sage-5.2          
      Component:  graph theory    |    Resolution:                    
       Keywords:  sparse6_string  |   Work issues:                    
Report Upstream:  N/A             |     Reviewers:  Nathann Cohen     
        Authors:  Birk Eisermann  |     Merged in:                    
   Dependencies:                  |      Stopgaps:                    
----------------------------------+-----------------------------------------

Comment (by kcrisman):

 This is indeed better.  Sage uses Python 2.7 so 2.4 is no problem :)  And
 it looks like the edges in question will already have integer labels at
 this point in the code, right? Nathann, I think this should be ok now.
 There is the deprecation period issue, but I'm assuming that you are
 vouching that this function had no actual graph-theoretic use, correct?  I
 suppose you could do the deprecation thing to cover all bases.  But this
 is a better solution in any case.

 I'm wondering about the whitespace changes - could give problems with
 conflicts with other patches.  You really only need two hunks here.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/13192#comment:8>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to