#5873: [patch] Fix matplotlib build on FreeBSD
-----------------------------------------------------------+----------------
Reporter: pjeremy | Owner:
mabshoff
Type: defect | Status:
needs_review
Priority: major | Milestone:
sage-duplicate/invalid/wontfix
Component: FreeBSD | Resolution:
Keywords: | Work issues:
Report Upstream: Completely fixed; Fix reported upstream | Reviewers:
Stephen Montgomery-Smith
Authors: | Merged in:
Dependencies: | Stopgaps:
-----------------------------------------------------------+----------------
Comment (by pi):
TLDR: you don't need this patch.
The mpl `setupext.py` code in question gets used when there is not an
entry for `basedirlist` in `setup.cfg`, in which case it'll grab it from
this pre-defined `basedir` dictionary using `sys.platform` as they key.
From what I see that's checked into hg for SAGE, you do define
`basedirlist` in `setup.cfg`, which is why this patch is un-necessary. The
code is in the SPKG `matplotlib.../make-setup-config.py:7`
{{{
config.set('directories', 'basedirlist', os.environ['SAGE_LOCAL'])
}}}
which is why this patch is not needed for SPKG matplotlib being built on
'''any''' platform.
From what I understand from the discussion at
[http://bugs.python.org/issue12326 Python Bug #12326], it seems like we
(MPL) should not have been using `sys.platform` in the first place for
making these decisions (but given the somewhat exotic nature of the
platforms which have exceptions there now, it's best to remain
conservative about re-writing that portion of the code to use something
like the `platform` modules). But to reiterate, the approach taken in the
SPKG bypasses this fragility for SAGE that is completely platform
independent.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/5873#comment:15>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
