#13140: OS X Lion doctest failures for double dense QR decomposition
----------------------------------+-----------------------------------------
Reporter: jdemeyer | Owner: jason, was
Type: defect | Status: needs_review
Priority: major | Milestone: sage-5.2
Component: linear algebra | Resolution:
Keywords: | Work issues:
Report Upstream: N/A | Reviewers: Rob Beezer
Authors: John Palmieri | Merged in:
Dependencies: #10795 | Stopgaps:
----------------------------------+-----------------------------------------
Changes (by rbeezer):
* reviewer: => Rob Beezer
* dependencies: => #10795
Comment:
Everything checks out fine on version 5.1.rc1 and all looks good. Thanks
for putting this together, maybe QR decomposition will finally be in good
order.
One final idea. I made a slightly different version of this routine
("inplace"), using the matrix routine that scales the column without
making a copy of the matrix. Runs about 10% faster on a moderately large
matrix.
{{{
sage: A = random_matrix(RDF, 1000)
sage: timeit("A._normalize_columns()")
5 loops, best of 3: 5.38 s per loop
sage: timeit("A._normalize_columns_inplace()")
5 loops, best of 3: 4.84 s per loop
}}}
Patch implements the suggested change, and the relevant tests pass when
applied. If you like it, then go ahead and add it to the list of patches
and flip this all to positive review. Thanks again.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/13140#comment:7>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
