#13140: OS X Lion doctest failures for double dense QR decomposition
---------------------------------------------+------------------------------
Reporter: jdemeyer | Owner: jason, was
Type: defect | Status: positive_review
Priority: major | Milestone: sage-5.2
Component: linear algebra | Resolution:
Keywords: | Work issues:
Report Upstream: N/A | Reviewers: Rob Beezer, John
Palmieri
Authors: John Palmieri, Rob Beezer | Merged in:
Dependencies: #10795 | Stopgaps:
---------------------------------------------+------------------------------
Changes (by {'newvalue': u'John Palmieri, Rob Beezer', 'oldvalue': u'John
Palmieri'}):
* status: needs_review => positive_review
* reviewer: Rob Beezer => Rob Beezer, John Palmieri
* author: John Palmieri => John Palmieri, Rob Beezer
Old description:
> The following doctest failure on OS X Lion is introduced by #10795:
> {{{
> sage -t "devel/sage/sage/matrix/matrix_double_dense.pyx"
> **********************************************************************
> File
> "/Users/palmieri/Desktop/Sage_stuff/sage_builds/clean/sage-5.1.beta5/devel/sage/sage/matrix/matrix_double_dense.pyx",
> line 2477:
> sage: Q.round(6).zero_at(10^-6)
> Expected:
> [-0.458831 0.126051 -0.381212 -0.394574 -0.68744]
> [-0.458831 -0.47269 0.051983 0.717294 -0.220963]
> [ 0.229416 -0.661766 -0.661923 -0.180872 0.196411]
> [ 0.688247 -0.189076 0.204468 0.09663 -0.662889]
> [-0.229416 -0.535715 0.609939 -0.536422 0.024551]
> Got:
> [-0.458831 -0.126051 0.381212 -0.394574 -0.68744]
> [-0.458831 0.47269 -0.051983 0.717294 -0.220963]
> [ 0.229416 0.661766 0.661923 -0.180872 0.196411]
> [ 0.688247 0.189076 -0.204468 0.09663 -0.662889]
> [-0.229416 0.535715 -0.609939 -0.536422 0.024551]
> **********************************************************************
> File
> "/Users/palmieri/Desktop/Sage_stuff/sage_builds/clean/sage-5.1.beta5/devel/sage/sage/matrix/matrix_double_dense.pyx",
> line 2483:
> sage: R.round(6).zero_at(10^-6)
> Expected:
> [ 4.358899 -0.458831 13.076697 6.194225 2.982405]
> [ 0.0 -1.670172 -0.598741 1.29202 -6.207997]
> [ 0.0 0.0 -5.444402 -5.468661 0.682716]
> [ 0.0 0.0 0.0 1.027626 -3.6193]
> [ 0.0 0.0 0.0 0.0 0.024551]
> Got:
> [ 4.358899 -0.458831 13.076697 6.194225 2.982405]
> [ 0.0 1.670172 0.598741 -1.29202 6.207997]
> [ 0.0 0.0 5.444402 5.468661 -0.682716]
> [ 0.0 0.0 0.0 1.027626 -3.6193]
> [ 0.0 0.0 0.0 0.0 0.024551]
> **********************************************************************
> File
> "/Users/palmieri/Desktop/Sage_stuff/sage_builds/clean/sage-5.1.beta5/devel/sage/sage/matrix/matrix_double_dense.pyx",
> line 2511:
> sage: Q.round(6).zero_at(10^-6)
> Expected:
> [ -0.730297 0.207057 + 0.538347*I -0.246305 + 0.076446*I
> 0.238162 - 0.10366*I]
> [ 0.091287 -0.207057 - 0.377878*I -0.378656 + 0.195222*I
> 0.701244 - 0.364371*I]
> [ 0.63901 + 0.091287*I 0.170822 + 0.667758*I 0.034115 - 0.040902*I
> 0.314017 - 0.082519*I]
> [ 0.182574 + 0.091287*I -0.036235 + 0.07247*I -0.863228 - 0.063228*I
> -0.449969 - 0.011612*I]
> Got:
> [ -0.730297 0.207057 + 0.538347*I 0.246305 - 0.076446*I
> 0.238162 - 0.10366*I]
> [ 0.091287 -0.207057 - 0.377878*I 0.378656 - 0.195222*I
> 0.701244 - 0.364371*I]
> [ 0.63901 + 0.091287*I 0.170822 + 0.667758*I -0.034115 + 0.040902*I
> 0.314017 - 0.082519*I]
> [ 0.182574 + 0.091287*I -0.036235 + 0.07247*I 0.863228 + 0.063228*I
> -0.449969 - 0.011612*I]
> **********************************************************************
> File
> "/Users/palmieri/Desktop/Sage_stuff/sage_builds/clean/sage-5.1.beta5/devel/sage/sage/matrix/matrix_double_dense.pyx",
> line 2516:
> sage: R.round(6).zero_at(10^-6)
> Expected:
> [ 10.954451 -1.917029*I 5.385938 - 2.19089*I
> -0.273861 - 2.19089*I]
> [ 0.0 4.829596 -0.869638 - 5.864879*I
> 0.993872 - 0.305409*I]
> [ 0.0 0.0 -12.001608
> 0.270953 - 0.442063*I]
> [ 0.0 0.0 0.0
> 1.942964]
> Got:
> [ 10.954451 -1.917029*I 5.385938 - 2.19089*I
> -0.273861 - 2.19089*I]
> [ 0.0 4.829596 -0.869638 - 5.864879*I
> 0.993872 - 0.305409*I]
> [ 0.0 0.0 12.001608
> -0.270953 + 0.442063*I]
> [ 0.0 0.0 0.0
> 1.942964]
> **********************************************************************
> File
> "/Users/palmieri/Desktop/Sage_stuff/sage_builds/clean/sage-5.1.beta5/devel/sage/sage/matrix/matrix_double_dense.pyx",
> line 2548:
> sage: R.round(6).zero_at(10^-6)
> Expected:
> [-5.567764 2.69408 -2.69408]
> [ 0.0 -3.569585 3.569585]
> [ 0.0 0.0 0.0]
> [ 0.0 0.0 0.0]
> Got:
> [ 5.567764 -2.69408 2.69408]
> [ 0.0 3.569585 -3.569585]
> [ 0.0 0.0 0.0]
> [ 0.0 0.0 0.0]
> **********************************************************************
> }}}
New description:
The following doctest failure on OS X Lion is introduced by #10795:
{{{
sage -t "devel/sage/sage/matrix/matrix_double_dense.pyx"
**********************************************************************
File
"/Users/palmieri/Desktop/Sage_stuff/sage_builds/clean/sage-5.1.beta5/devel/sage/sage/matrix/matrix_double_dense.pyx",
line 2477:
sage: Q.round(6).zero_at(10^-6)
Expected:
[-0.458831 0.126051 -0.381212 -0.394574 -0.68744]
[-0.458831 -0.47269 0.051983 0.717294 -0.220963]
[ 0.229416 -0.661766 -0.661923 -0.180872 0.196411]
[ 0.688247 -0.189076 0.204468 0.09663 -0.662889]
[-0.229416 -0.535715 0.609939 -0.536422 0.024551]
Got:
[-0.458831 -0.126051 0.381212 -0.394574 -0.68744]
[-0.458831 0.47269 -0.051983 0.717294 -0.220963]
[ 0.229416 0.661766 0.661923 -0.180872 0.196411]
[ 0.688247 0.189076 -0.204468 0.09663 -0.662889]
[-0.229416 0.535715 -0.609939 -0.536422 0.024551]
**********************************************************************
File
"/Users/palmieri/Desktop/Sage_stuff/sage_builds/clean/sage-5.1.beta5/devel/sage/sage/matrix/matrix_double_dense.pyx",
line 2483:
sage: R.round(6).zero_at(10^-6)
Expected:
[ 4.358899 -0.458831 13.076697 6.194225 2.982405]
[ 0.0 -1.670172 -0.598741 1.29202 -6.207997]
[ 0.0 0.0 -5.444402 -5.468661 0.682716]
[ 0.0 0.0 0.0 1.027626 -3.6193]
[ 0.0 0.0 0.0 0.0 0.024551]
Got:
[ 4.358899 -0.458831 13.076697 6.194225 2.982405]
[ 0.0 1.670172 0.598741 -1.29202 6.207997]
[ 0.0 0.0 5.444402 5.468661 -0.682716]
[ 0.0 0.0 0.0 1.027626 -3.6193]
[ 0.0 0.0 0.0 0.0 0.024551]
**********************************************************************
File
"/Users/palmieri/Desktop/Sage_stuff/sage_builds/clean/sage-5.1.beta5/devel/sage/sage/matrix/matrix_double_dense.pyx",
line 2511:
sage: Q.round(6).zero_at(10^-6)
Expected:
[ -0.730297 0.207057 + 0.538347*I -0.246305 + 0.076446*I
0.238162 - 0.10366*I]
[ 0.091287 -0.207057 - 0.377878*I -0.378656 + 0.195222*I
0.701244 - 0.364371*I]
[ 0.63901 + 0.091287*I 0.170822 + 0.667758*I 0.034115 - 0.040902*I
0.314017 - 0.082519*I]
[ 0.182574 + 0.091287*I -0.036235 + 0.07247*I -0.863228 - 0.063228*I
-0.449969 - 0.011612*I]
Got:
[ -0.730297 0.207057 + 0.538347*I 0.246305 - 0.076446*I
0.238162 - 0.10366*I]
[ 0.091287 -0.207057 - 0.377878*I 0.378656 - 0.195222*I
0.701244 - 0.364371*I]
[ 0.63901 + 0.091287*I 0.170822 + 0.667758*I -0.034115 + 0.040902*I
0.314017 - 0.082519*I]
[ 0.182574 + 0.091287*I -0.036235 + 0.07247*I 0.863228 + 0.063228*I
-0.449969 - 0.011612*I]
**********************************************************************
File
"/Users/palmieri/Desktop/Sage_stuff/sage_builds/clean/sage-5.1.beta5/devel/sage/sage/matrix/matrix_double_dense.pyx",
line 2516:
sage: R.round(6).zero_at(10^-6)
Expected:
[ 10.954451 -1.917029*I 5.385938 - 2.19089*I
-0.273861 - 2.19089*I]
[ 0.0 4.829596 -0.869638 - 5.864879*I
0.993872 - 0.305409*I]
[ 0.0 0.0 -12.001608
0.270953 - 0.442063*I]
[ 0.0 0.0 0.0
1.942964]
Got:
[ 10.954451 -1.917029*I 5.385938 - 2.19089*I
-0.273861 - 2.19089*I]
[ 0.0 4.829596 -0.869638 - 5.864879*I
0.993872 - 0.305409*I]
[ 0.0 0.0 12.001608
-0.270953 + 0.442063*I]
[ 0.0 0.0 0.0
1.942964]
**********************************************************************
File
"/Users/palmieri/Desktop/Sage_stuff/sage_builds/clean/sage-5.1.beta5/devel/sage/sage/matrix/matrix_double_dense.pyx",
line 2548:
sage: R.round(6).zero_at(10^-6)
Expected:
[-5.567764 2.69408 -2.69408]
[ 0.0 -3.569585 3.569585]
[ 0.0 0.0 0.0]
[ 0.0 0.0 0.0]
Got:
[ 5.567764 -2.69408 2.69408]
[ 0.0 3.569585 -3.569585]
[ 0.0 0.0 0.0]
[ 0.0 0.0 0.0]
**********************************************************************
}}}
----------------
Apply [attachment:trac_13140_double_dense.patch] and
[attachment:trac_13140-rescale-inplace.patch].
--
Comment:
Looks good to me.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/13140#comment:8>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
