#13207: Please consider updating to gfan 0.5
-------------------------------+--------------------------------------------
       Reporter:  pcpa         |         Owner:  was                           
           Type:  enhancement  |        Status:  closed                        
       Priority:  minor        |     Milestone:  sage-duplicate/invalid/wontfix
      Component:  interfaces   |    Resolution:  duplicate                     
       Keywords:               |   Work issues:                                
Report Upstream:  N/A          |     Reviewers:  Marshall Hampton              
        Authors:               |     Merged in:                                
   Dependencies:               |      Stopgaps:                                
-------------------------------+--------------------------------------------
Changes (by jdemeyer):

  * status:  positive_review => closed
  * resolution:  => duplicate


Old description:

> As far as I checked, the sagemath gfan spkg patches are already applied
> to gfan 0.5.
>
> I made a few changes to the package in a RFE (request for enhancement) to
> the gfan 0.5 fedora package at
> https://bugzilla.redhat.com/show_bug.cgi?id=837857. Most noticeable one
> should be that I added a gfan-permissive.patch to make it work if called
> as `gfan` instead of erroring out and telling to call it `gfan_bases`.
> But it could be changed to be called as 'gfan_bases' in
> `sage/interfaces/gfan.py`.
>
> The major issue I noticed is that, the first previous doctest failure due
> to it wanting to be called `gfan_bases` now gives a different result in
> one of the tests:
>
> {{{
> $ sage -t  -force_lib "devel/doc/en/tutorial/tour_advanced.rst"
> sage -t -force_lib "devel/doc/en/tutorial/tour_advanced.rst"
> **********************************************************************
> File "/usr/share/sagemath/devel/doc/en/tutorial/tour_advanced.rst", line
> 66:
>     sage: F.reduced_groebner_bases ()
> Expected:
>     [[-c^2 + b*d, -b*c + a*d, -b^2 + a*c],
>      [c^2 - b*d, -b*c + a*d, -b^2 + a*c],
>      [c^2 - b*d, b*c - a*d, -b^2 + a*c, -b^3 + a^2*d],
>      [c^2 - b*d, b*c - a*d, b^3 - a^2*d, -b^2 + a*c],
>      [c^2 - b*d, b*c - a*d, b^2 - a*c],
>      [-c^2 + b*d, b^2 - a*c, -b*c + a*d],
>      [-c^2 + b*d, b*c - a*d, b^2 - a*c, -c^3 + a*d^2],
>      [c^3 - a*d^2, -c^2 + b*d, b*c - a*d, b^2 - a*c]]
> Got:
>     [[-c^2 + b*d, -b*c + a*d, -b^2 + a*c], [-c^2 + b*d, b^2 - a*c, -b*c +
> a*d], [-c^2 + b*d, b*c - a*d, b^2 - a*c, -c^3 + a*d^2], [c^3 - a*d^2,
> -c^2 + b*d, b*c - a*d, b^2 - a*c], [c^2 - b*d, -b*c + a*d, -b^2 + a*c],
> [c^2 - b*d, b*c - a*d, -b^2 + a*c, -b^3 + a^2*d], [c^2 - b*d, b*c - a*d,
> b^3 - a^2*d, -b^2 + a*c], [c^2 - b*d, b*c - a*d, b^2 - a*c]]
> **********************************************************************
> 1 items had failures:
>    1 of   8 in __main__.example_1
> ***Test Failed*** 1 failures.
> For whitespace errors, see the file
> /home/pcpa/.sage//tmp/tour_advanced_19053.py
>          [5.8 s]
>
> ----------------------------------------------------------------------
> The following tests failed:
>

>         sage -t -force_lib "devel/doc/en/tutorial/tour_advanced.rst"
> Total time for all tests: 5.8 seconds
>
> }}}
> For easier noticing the different result, the diff is:
>
> {{{
> $ diff -u ~/{old,new}
> --- /home/pcpa/old      2012-07-05 12:27:50.823418301 -0400
> +++ /home/pcpa/new      2012-07-05 12:27:56.591418588 -0400
> @@ -1,8 +1,8 @@
>      [[-c^2 + b*d, -b*c + a*d, -b^2 + a*c],
> +     [-c^2 + b*d, b^2 - a*c, -b*c + a*d],
> +     [-c^2 + b*d, b*c - a*d, b^2 - a*c, -c^3 + a*d^2],
> +     [c^3 - a*d^2, -c^2 + b*d, b*c - a*d, b^2 - a*c],
>       [c^2 - b*d, -b*c + a*d, -b^2 + a*c],
>       [c^2 - b*d, b*c - a*d, -b^2 + a*c, -b^3 + a^2*d],
>       [c^2 - b*d, b*c - a*d, b^3 - a^2*d, -b^2 + a*c],
> -     [c^2 - b*d, b*c - a*d, b^2 - a*c],
> -     [-c^2 + b*d, b^2 - a*c, -b*c + a*d],
> -     [-c^2 + b*d, b*c - a*d, b^2 - a*c, -c^3 + a*d^2],
> -     [c^3 - a*d^2, -c^2 + b*d, b*c - a*d, b^2 - a*c]]
> +     [c^2 - b*d, b*c - a*d, b^2 - a*c]]
> }}}

New description:

 As far as I checked, the sagemath gfan spkg patches are already applied to
 gfan 0.5.

 I made a few changes to the package in a RFE (request for enhancement) to
 the gfan 0.5 fedora package at
 https://bugzilla.redhat.com/show_bug.cgi?id=837857. Most noticeable one
 should be that I added a gfan-permissive.patch to make it work if called
 as `gfan` instead of erroring out and telling to call it `gfan_bases`. But
 it could be changed to be called as 'gfan_bases' in
 `sage/interfaces/gfan.py`.

 See #11395 instead.

--

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/13207#comment:5>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to