#13259: Correcting implementation of "negative" quantum integers
-----------------------------------+----------------------------------------
       Reporter:  andrew.mathas    |         Owner:  sage-combinat
           Type:  defect           |        Status:  needs_review 
       Priority:  minor            |     Milestone:  sage-5.3     
      Component:  combinatorics    |    Resolution:               
       Keywords:  quantum integer  |   Work issues:               
Report Upstream:  N/A              |     Reviewers:               
        Authors:                   |     Merged in:               
   Dependencies:                   |      Stopgaps:               
-----------------------------------+----------------------------------------

Comment (by arminstraub):

 This is my first attempt at reviewing a ticket so please let me know if I
 am breaking any rules...

 I just uploaded an update to your patch which addresses the following:
 * I tried to correctly format the doc strings (but as I am no export on
 documentation, it would be good if somebody could check).
 * Added an initial check whether n is an integer (previously, q_int(3/2)
 would result in 0 without complaint).

 Because of these changes, I am leaving this ticket as needing review.

 patchbot: apply trac_13259-negative_quantum_integers-am.patch
 trac_13259-review.patch

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/13259#comment:5>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to