#9265: Remove `CombinatorialClass` from sage.combinat.tableau
------------------------------------------------+---------------------------
Reporter: jbandlow | Owner: sage-combinat
Type: enhancement | Status:
positive_review
Priority: major | Milestone: sage-5.3
Component: combinatorics | Resolution:
Keywords: tableaux, combinatorics | Work issues:
Report Upstream: N/A | Reviewers: Andrew
Mathas, Anne Schilling
Authors: Jason Bandlow, Andrew Mathas | Merged in:
Dependencies: | Stopgaps:
------------------------------------------------+---------------------------
Comment (by nthiery):
Replying to [comment:18 andrew.mathas]:
> As the patchbot was complaining, I just uploaded a new version of the
patch which deletes all trailing white space. Probably this is unwise as
previously I used to have my editor do this automatically but I found that
it meant that I had to rebase my patch all of the time so this will
probably cause havoc further down the queue?
>
> What is the accepted practise here?
For the record: removing all trailing white spaces is indeed likely to
produce conflicts.
So I usually just make sure in my patch to not introduce new ones
(sometimes, I edit the patch directly to remove those that I introduced
accidently), and to remove those that are very close to the lines I change
anyway.
Now in the case at hand, you currently kind of own the tableau file, since
everybody knows that you are working hard on it, and that it is thus not
safe playing with it. Then, the potential conflicts are with yourself, so
you are free to take whichever course of action which is practical for
you.
Thanks for your work!
Nicolas
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9265#comment:33>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
