#13324: Upgrade ECL to 12.7.1 and let it build on (recent) Cygwins
----------------------------------------------------------------+-----------
Reporter: jpflori |
Owner: tbd
Type: defect |
Status: needs_review
Priority: major |
Milestone: sage-5.3
Component: cygwin |
Resolution:
Keywords: cygwin ecl spkg | Work
issues:
Report Upstream: Fixed upstream, but not in a stable release. |
Reviewers:
Authors: Jean-Pierre Flori | Merged
in:
Dependencies: |
Stopgaps:
----------------------------------------------------------------+-----------
Old description:
> On my 1.7.16 installation of Cygwin, the ecl spkg does not build because
> it defines unconditionaly _WINSOCKAPI_ in h/ecl-cmp.h which then prevents
> the definition of fd_set in /usr/include/sys/types.h.
> I guess this is harmless on linux, intended on Windows, but on Cygwin
> this breaks the build of ECL.
>
> The proposed spkg patches h/ecl-cmp.h so that _WINSOCKAPI_ is not defined
> on CYGWIN.
> This has been merged upstream:
> https://sourceforge.net/p/ecls/ecl/ci/07c4ab7db83eda2eed7fa4a5ddeec2e28c7eb58b/
>
> Try spkg at
> http://perso.telecom-
> paristech.fr/~flori/sage/ecl-11.1.2.cvs20111120.p2.spkg
New description:
On my 1.7.16 installation of Cygwin, the ecl spkg does not build because
it defines unconditionaly _WINSOCKAPI_ in h/ecl-cmp.h which then prevents
the definition of fd_set in /usr/include/sys/types.h.
I guess this is harmless on Linux, intended on Windows, but on Cygwin this
breaks the build of ECL.
The proposed spkg patches h/ecl-cmp.h so that _WINSOCKAPI_ is not defined
on CYGWIN.
This has been merged upstream:
https://sourceforge.net/p/ecls/ecl/ci/07c4ab7db83eda2eed7fa4a5ddeec2e28c7eb58b/
Try spkg at
http://perso.telecom-paristech.fr/~flori/sage/ecl-12.7.1.p0.spkg
which includes upstream version 12.7.1 and the above fix.
Apply [attachment:trac_13324.patch]
--
Comment (by jpflori):
I've upped an updated ECL spkg which includes upstream version 12.7.1 plus
the git commit corresponding to the fix originally proposed here.
It's at
http://perso.telecom-paristech.fr/~flori/sage/ecl-12.7.1.p0.spkg
I've updated the spkg-make file and homogenized the indentation in the
spkg-install file as well.
Two trivial doctests had to be changed, and it passes make ptestlong on
Ubuntu 12.04 64 bits.
No time to retest Cygwin yet.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/13324#comment:11>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
