#12313: Fix yet another memory leak caused by caching of coercion data
--------------------------------------------------+-------------------------
Reporter: SimonKing | Owner:
Type: defect | Status:
needs_review
Priority: major | Milestone: sage-5.3
Component: memleak | Resolution:
Keywords: coercion weak dictionary | Work issues:
Report Upstream: N/A | Reviewers: Simon King,
Jean-Pierre Flori, John Perry
Authors: Simon King, Jean-Pierre Flori | Merged in:
Dependencies: #11521, #11599, #12969, #12215 | Stopgaps:
--------------------------------------------------+-------------------------
Changes (by SimonKing):
* status: needs_work => needs_review
* work_issues: Test activity of weak references if addresses coincide =>
Comment:
I have updated the patch. Change: Before returning a value of the
dictionary or assert that a key is in the dictionary, I test whether the
keyed references involved are still active. If they are not, then the key
just happens to use the old memory location for new values.
I have already tested that the error (that I only find with #13370)
disappears with the new patches. I am now running make ptest with #13370.
I only wonder whether the additional tests imply an unacceptable slow-
down. Could the reviewer do some tests? I am about to be on holiday, so,
very likely I can't test much in the next few days.
Apply trac_12313-mono_dict-combined-random-sk.patch
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12313#comment:147>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
