#13389: Minor fix to LiE optional SPKG
-------------------------------------+--------------------------------------
       Reporter:  kini               |         Owner:  tbd            
           Type:  enhancement        |        Status:  positive_review
       Priority:  major              |     Milestone:  sage-5.3       
      Component:  optional packages  |    Resolution:                 
       Keywords:                     |   Work issues:                 
Report Upstream:  N/A                |     Reviewers:  John Palmieri  
        Authors:  Keshav Kini        |     Merged in:                 
   Dependencies:                     |      Stopgaps:                 
-------------------------------------+--------------------------------------
Changes (by jhpalmieri):

  * status:  needs_review => positive_review
  * reviewer:  => John Palmieri


Comment:

 There is still a doctest failure on some platforms:
 {{{
 **********************************************************************
 File "/scratch/palmieri/sage-5.3.beta2/devel/sage/sage/interfaces/lie.py",
 line 504:
     sage: lie.trait_names() # optional - lie
 Expected:
     ['Cartan_type',
      'cent_roots',
      ...
      'n_comp']
 Got:
     ['history', 'version', 'operators', 'function', 'type', 'integer',
 'vector', 'matrix', 'group', 'text', 'polynomial', 'special', 'help',
 'assignment', 'if', 'for', 'commands', 'on', 'off', 'quit', 'edit',
 'break', 'error', 'print', 'void', 'files', 'write', 'read', 'monitor',
 'save', 'setdefault', 'finish', 'Cartan_type', 'cent_roots', 'centr_type',
 'closure', 'fundam', 'canonical', 'dominant', 'filter_dom', 'W_action',
 'W_rt_action', 'W_word', 'from_part', 'to_part', 'res_mat', 'n_rows',
 'n_cols', 'vecmat', 'save_mat', 'unique', 'sort', 'center', 'diagram',
 'dim', 'Lie_code', 'Lie_rank', 'Cartan', 'det_Cartan', 'high_root',
 'i_Cartan', 'n_pos_roots', 'pos_roots', 'exponents', 'W_order', 'adjoint',
 'max_sub', 'res_mat', 'res_mat', 'n_comp', 'Lie_group', 'orbit',
 'partitions', 'Adams', 'Adams', 'alt_tensor', 'alt_tensor', 'max_sub',
 'p_tensor', 'p_tensor', 'sym_tensor', 'sym_tensor', 'null', 'null',
 'all_one', 'all_one', 'poly_null', 'poly_one', 'id', 'factor', 'get_mat',
 'save_string', 'get_string', 'dominant', 'filter_dom', 'W_action',
 'W_orbit', 'from_part', 'to_part', 'alt_dom', 'alt_dom', 'alt_W_sum',
 'branch', 'collect', 'collect', 'contragr', 'decomp', 'Demazure',
 'Demazure', 'dim', 'dom_char', 'dom_char', 'LR_tensor', 'spectrum',
 'tensor', 'tensor', 'v_decomp', 'degree', 'expon', 'coef', 'n_vars',
 'length', 'Cartan', 'cent_roots', 'centr_type', 'dom_weights', 'inprod',
 'norm', 'Bruhat_desc', 'Bruhat_desc', 'Bruhat_leq', 'canonical',
 'dominant', 'KL_poly', 'length', 'long_word', 'l_reduce', 'lr_reduce',
 'orbit', 'reduce', 'reflection', 'R_poly', 'r_reduce', 'W_action',
 'W_action', 'W_orbit', 'W_orbit_size', 'W_order', 'W_rt_action',
 'W_rt_action', 'W_rt_orbit', 'W_word', 'class_ord', 'from_part',
 'next_part', 'next_perm', 'next_tabl', 'next_tabl', 'print_tab', 'RS',
 'RS', 'sign_part', 'shape', 'sym_char', 'sym_char', 'sym_orbit',
 'tableaux', 'to_part', 'trans_part', 'alt_dom', 'alt_dom', 'alt_W_sum',
 'branch', 'contragr', 'Demazure', 'Demazure', 'dim', 'dom_char',
 'dom_char', 'LR_tensor', 'plethysm', 'plethysm', 'spectrum', 'tensor',
 'tensor', 'v_decomp', 'size', 'matvec', 'sort']
 **********************************************************************
 }}}
 If you want to fix it, you can (e.g., test whether `'Cartan' in
 lie.trait_names()` returns True). It's not very important to me since it's
 an optional spkg, and the documentation needs a lot of work anyway: do any
 of the methods actually have docstrings beyond an EXAMPLES block?

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/13389#comment:8>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to