#11641: Implementation of decorator for combinatorial maps
-------------------------------------------+--------------------------------
Reporter: stumpc5 | Owner: sage-combinat
Type: enhancement | Status: needs_info
Priority: major | Milestone: sage-pending
Component: combinatorics | Resolution:
Keywords: combinatorial statistic | Work issues: move file into
combinat tree ; address TODOs in the file
Report Upstream: N/A | Reviewers:
Authors: Christian Stump | Merged in:
Dependencies: | Stopgaps:
-------------------------------------------+--------------------------------
Comment (by chrisjamesberg):
Hey Christian,
> - I deleted the files we don't need (I do have permission as well).
Thanks!
> - trac_11641_concrete_combinatorial_maps_cb.patch is full of things we
should not take care of (all the removed whitespaces) - in particular this
doesn't let me apply the patch on 5.2 (and we are on holidays so I cannot
download and compile 5.3.beta2).
The reason for this is just that I was cutting and pasting code our old
code from the combinat server. Should I really go through and put all the
whitespace back in?
> - Examples in Franco's review do depend on
trac_11641_concrete_combinatorial_maps_cb.patch, so I think the concrete
maps should come right after the decorator.
Agreed.
> - I deleted the combinatorial_statistics from my patch (and its deletion
from Franco's), and then moved the decorator to
sage.combinat.combinatorial_map.
Perfect.
> - All the concrete maps I implemented in the past months are missing in
the patch (e.g. the one sending area-bounce to dinv-area,and also all
other maps for Dyck words).
I didn't include all of our work from combinat because a lot of it was
missing proper documentation. Our thought was, lets get this working with
what's already in sage, and then adding all the maps you've created are
very simple patches. I did include a few combinatorial maps, as long as
the documentation was there and it was self contained, though it's
possible I missed one or two.
> - I looked at the TODO's in Franco's review. As I said, I simply copied
another decorator, so I can't really answer all the questions (e.g. I
don't know what this "f=None" is used for). If you haven't done it
earlier, I will look more closely at it after next week when we are back
from holidays - or if we have a rainy day in between, like today :-) .
Enjoy the holidays. Tell Anke and Jara I say hello.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11641#comment:20>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
