#11641: Implementation of decorator for combinatorial maps
-------------------------------------------+--------------------------------
Reporter: stumpc5 | Owner: sage-combinat
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-pending
Component: combinatorics | Resolution:
Keywords: combinatorial statistic | Work issues: move file into
combinat tree
Report Upstream: N/A | Reviewers:
Authors: Christian Stump | Merged in:
Dependencies: | Stopgaps:
-------------------------------------------+--------------------------------
Comment (by stumpc5):
Replying to [comment:20 chrisjamesberg]:
> The reason for this is just that I was cutting and pasting code our old
code from the combinat server. Should I really go through and put all the
whitespace back in?
I shrinked the patch to the stuff we want - I hope I didn't mess anything,
please recheck and modify if you find anything.
> > Examples in Franco's review do depend on
trac_11641_concrete_combinatorial_maps_cb.patch, so I think the concrete
maps should come right after the decorator.
>
> Agreed.
done.
> > All the concrete maps I implemented in the past months are missing in
the patch (e.g. the one sending area-bounce to dinv-area,and also all
other maps for Dyck words).
>
> I didn't include all of our work from combinat because a lot of it was
missing proper documentation. Our thought was, lets get this working with
what's already in sage, and then adding all the maps you've created are
very simple patches. I did include a few combinatorial maps, as long as
the documentation was there and it was self contained, though it's
possible I missed one or two.
agreed, but we have to keep in mind to prepare another trac ticket for the
remaining stuff (where we shouldn't forget any of the implemented
methods!).
> > I looked at the TODO's in Franco's review.
I went through all of them and added a review-review, please have a look!
I now wonder what the patchpot says...
Best, Christian
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11641#comment:22>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
