#13325: eclib does not build on Cygwin
------------------------------------------------------------+---------------
Reporter: jpflori | Owner:
tbd
Type: defect | Status:
needs_review
Priority: major | Milestone:
sage-5.3
Component: cygwin | Resolution:
Keywords: eclib spkg cygwin | Work issues:
Report Upstream: Workaround found; Bug reported upstream. | Reviewers:
Authors: Jean-Pierre Flori | Merged in:
Dependencies: #13333 | Stopgaps:
------------------------------------------------------------+---------------
Comment (by cremona):
Replying to [comment:59 jpflori]:
> Looks really nice.
Thanks.
>
> In tests dir, you forgot to replace LDADD by LIBS and the dependencies
of check targets by binaries names with EXEEXT appended (it should work as
is, even on Cygwin, but for a bad reason as mentioned before).
Fixed.
>
> And unfortunately, I don't think the echo -e command is portable.
> For example it will behave differently on bash and dash.
> (On of them will just print -e and will not interpret the \c).
>
Fixed. The testing just outputs the test name (one per line) as it goes,
with no "done" at the end since that would go on a separate line which did
not look good. So, no news is good news for test output.
> Finally, as I'm a little confused by your answer about what programs in
progs are built/check, I did not suggest not to check every program when
allprogs is not set and make check is run.
>
Fixed (see below)
> In fact I rather suggested to always build and install (and check) every
program, i.e. remove the allprogs option.
> Hence, in the future, if Sage uses more programs from your package it
wont need further modification (and it will only take a little more time,
and a tiny amount of memory, when built for Sage).
>
> If you want to keep the option, i suggest you add the programs different
from mwrank in check_PROGRAMS when the option is disabled (I'd say you
could even include mwrank for simplicity, to use the already defined
variables).
> That way, automake will generate its magic targets to build the
executables (Ive not tested yet, but Id say the generated Makefile won't
include anything specific currently and they will be built generically...
and surely fail).
I have kept the allprogs option (set to true by default). When false:
"make" builds the library and mwrank only (nothing in tests, nor the other
prgrams in progs) while "make check" builds and tests everything. When
true: "make" builds the library and all programs in progs (nothing in
tests) while "make check" builds and tests everything.
There's anew tarball at
http://homepages.warwick.ac.uk/staff/J.E.Cremona/ftp/eclib-2012-08-24.tar.gz
and I am about to push these changes to https://code.google.com/p/eclib/ .
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/13325#comment:61>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
