#12313: Fix yet another memory leak caused by caching of coercion data
--------------------------------------------------+-------------------------
Reporter: SimonKing | Owner:
Type: defect | Status:
needs_review
Priority: major | Milestone: sage-5.3
Component: memleak | Resolution:
Keywords: coercion weak dictionary | Work issues:
Report Upstream: N/A | Reviewers: Simon King,
Jean-Pierre Flori, John Perry
Authors: Simon King, Jean-Pierre Flori | Merged in:
Dependencies: #11521, #11599, #12969, #12215 | Stopgaps:
--------------------------------------------------+-------------------------
Comment (by SimonKing):
Replying to [comment:241 nbruin]:
> Replying to [comment:238 jpflori]:
> `GroebnerStrategy.__init__`:
> - Creates a new `ReductionStrategy` wrapper and stores it in
`self.reduction_strategy`
> - Asks polybori to delete the `self.reduction_strategy._strat`
attribute on it
> - Then fills that slot with `&self._strat.generators`
> So `GroebnerStrategy.reduction_strategy._strat` is now definitely a
borrowed reference from `ReductionStrategy`.
No, the reduction strategy borrows from the Gröbner strategy.
> However, that's assuming that we can establish whether
`GroebnerStrategy.reduction_strategy` is still valid upon deallocation.
Since `GroebnerStrategy` has borrowed the reference without
`ReductionStrategy` really knowing, I think `GroebnerStrategy` should just
not delete `_strat`.
But who else should?
> In due time, `ReductionStrategy.__dealloc__` gets called and will clean
up the ref. It's hers!
No. `reduction_strategy._strat` does not borrow a reference to `_strat`
(hence, `ReductionStrategy.__dealloc__` does ''not'' dealloc
`GroebnerStrategy._strat`), but it borrows a reference to
`_strat.generators`.
That's why I think Jean-Pierre's solution is logical: Explicitly tell
`ReductionStrategy` whether its `_strat` is borrowed from a
`GroebnerStrategy`'s `_strat.generators`.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12313#comment:242>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
