#12313: Fix yet another memory leak caused by caching of coercion data
--------------------------------------------------+-------------------------
Reporter: SimonKing | Owner:
Type: defect | Status:
positive_review
Priority: major | Milestone: sage-5.3
Component: memleak | Resolution:
Keywords: coercion weak dictionary | Work issues:
Report Upstream: N/A | Reviewers: Simon King,
Jean-Pierre Flori, John Perry, Nils Bruin
Authors: Simon King, Jean-Pierre Flori | Merged in:
Dependencies: #11521, #11599, #12969, #12215 | Stopgaps:
--------------------------------------------------+-------------------------
Changes (by nbruin):
* status: needs_review => positive_review
* reviewer: Simon King, Jean-Pierre Flori, John Perry => Simon King,
Jean-Pierre Flori, John Perry, Nils Bruin
Comment:
Speed regression mitigation is definitely going onto another ticket. The
consensus here is clearly that reasonable memory use trumps a (relatively
small) speed penalty. I'm not so sure that the doctests are such a good
measure fore "performance" anyway. They mainly measure construction of
tiny examples, so tend to concentrate on overhead that is fairly
irrelevant (because not in inner loops) in practice. I'm not surprised
we're not doing so well in that park, but we already have some small
improvements on future tickets (although I bet the main penalty is coming
from NOT having things cached anymore sometimes).
Anyway, the code here (and on the dependencies of this ticket!) has been
discussed and vetted to death already. Bot's complaining about a bit of
whitespace, which should be trivial to fix. In anticipation of that
getting removed:
'''POSITIVE REVIEW!!!'''
Congratulations, to all who participated and especially Simon for an
incredible diligence and calm in pushing through this at times seemingly
hopeless process.
There are a lot of people in the review field of this ticket. If any of
them dissent with the status, they can take action.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12313#comment:248>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
