#13365: Add Semidirect Product Method for Permutation Groups
-------------------------------------------------+--------------------------
Reporter: khalasz | Owner: joyner
Type: enhancement | Status: needs_work
Priority: minor | Milestone: sage-5.3
Component: group theory | Resolution:
Keywords: groups semidirect product GAP | Work issues: fix failing
doctests
Report Upstream: N/A | Reviewers: Benjamin
Jones
Authors: Kevin Halasz | Merged in:
Dependencies: | Stopgaps:
-------------------------------------------------+--------------------------
Changes (by benjaminfjones):
* status: needs_review => needs_work
* work_issues: => fix failing doctests
Comment:
Sorry for the delay, I've been out of town.
Good catch about the bijection check. I think the `check` optional
parameter is a good idea. The only comment I have after reading over your
most recent patch is that you should document what the `check` parameter
does in the docstring somewhere, preferably under the description of the
two required parameters.
Also, the most recent patch applies cleanly to sage-5.3.rc0 but there are
a few failing doctests in `sage/groups/perm_gps/permgroup.py`, one of them
is just a difference in the text of a thrown exception, but there are
others.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/13365#comment:12>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
