#10538: Implementation of the class ClusterQuiver
-------------------------------------------+--------------------------------
Reporter: stumpc5 | Owner:
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-5.3
Component: combinatorics | Resolution:
Keywords: cluster algebra, quiver | Work issues:
Report Upstream: N/A | Reviewers: Gregg Musiker
Authors: Christian Stump | Merged in:
Dependencies: #10527 | Stopgaps:
-------------------------------------------+--------------------------------
Comment (by stumpc5):
Comments on your patch:
- In the documentation, you use
{{{
sage: MT = Q._mutation_type
}}}
Please use
{{{
sage: MT = Q.mutation_type()
}}}
instead since _ methods and attributes should not be used there, if
possible.
- "Returns the restriction to the principal part (i.e. exchangeable part)
of self. I.e., the subquiver obtained by deleting the frozen vertices of
self." contains two times i.e. . Could you change that?
- `if type(inplace) is Integer:` Instead of printing a warning, I would
suggest to only allow boolean arguments here, and raise a !ValueError
otherwise.
- `elif rank == 4 and (twist == [1,2] or twist == [2,1])` Am I seeing it
right that you now introduced two !QuiverMutationTypes for the two
possible twists? I would certainly not like that since both are mutation
equivalent. [ I just think about the same kind of behaviour in type D and
affine A with an oriented circle - it doesn't seem that you actually
treated this case, did you? ] I still prefer the standard quiver method to
have an optional argument, but we can maybe discuss that again later today
or tomorrow...
Beside that, all changes seem good to me.
Best, Christian
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/10538#comment:23>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
