#10538: Implementation of the class ClusterQuiver
-------------------------------------------+--------------------------------
Reporter: stumpc5 | Owner:
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-5.3
Component: combinatorics | Resolution:
Keywords: cluster algebra, quiver | Work issues:
Report Upstream: N/A | Reviewers: Gregg Musiker
Authors: Christian Stump | Merged in:
Dependencies: #10527 | Stopgaps:
-------------------------------------------+--------------------------------
Comment (by gmoose05):
Christian, the changes we discussed have now been essentially made:
* The ClusterQuiver constructor passes along all inputs which are of the
form QuiverMutationType to .standard_quiver()
* However, does case-by-case handling of (C,2), (F,4, [2,1]), (G,2,
(3,1)), 'GR' type, and 'TR' type.
Note that I employed a strategy slightly different than we discussed: I
use QuiverMutationType_Irreducible._digraph to get
the desired directed graph rather than repeating these lines here.
If you want to move some of these lines from
QuiverMutationType_Irreducible to here, we can do that, but I wanted to
make sure it worked first before trying to pull those lines over. Also,
I'm perfectly happy leaving the lines in QuiverMutationType_Irreducible
since it is not a globally defined class, but am open to further
discussion.
* I also now allow an input of
{{{
sage: QuiverMutationType(['A',[n,0],1])
['D', n]
}}}
with special cases for small n.
However
{{{
sage: ClusterQuiver(['A',[n,0],1])
}}}
yields the directed cycle quiver of type D_n rather than the standard
Dynkin D_n.
* ClusterQuiver now also has the command .mutation_type() which yields the
_mutation_type, but without trying to compute it when it is not already
known.
* I found out where in our code we are missing doctests. It is really
only for the graphical commands: .plot(), .show() in QuiverMutationType.py
and .show(), .interact(), and .save_image() in Quiver.py.
I added a dummy example for .plot() in QuiverMutationType but didn't
update the others. Hopefully adding this one function changed the
coverage percentage so that we increase it rather than decrease it (I
think that's what made the patchbot unhappy).
We also have bad coverage in the mutation_class.py file, but state that at
the top of the sheet, and I will worry about this another day.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/10538#comment:25>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
