The branch, master has been updated
       via  a53a8ec... Revert "libcli/security: Prohibit SID formats like 
S-1-5-32-+545"
      from  b5d4726... s4-smbtorture: test 
wbcResolveWinsByName/wbcResolveWinsByIP in WINBIND-WBCLIENT testsuite.

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master


- Log -----------------------------------------------------------------
commit a53a8ec45245353d978e6f845c41d76b2e12a3c6
Author: Volker Lendecke <[email protected]>
Date:   Mon Jan 25 12:39:47 2010 +0100

    Revert "libcli/security: Prohibit SID formats like S-1-5-32-+545"
    
    This reverts commit 1fbeae41655b8305834f2149b1268077eba8633d.
    
    Apparently this breaks the build of Samba4

-----------------------------------------------------------------------

Summary of changes:
 libcli/security/dom_sid.c |   13 -------------
 1 files changed, 0 insertions(+), 13 deletions(-)


Changeset truncated at 500 lines:

diff --git a/libcli/security/dom_sid.c b/libcli/security/dom_sid.c
index 8a2ed1f..6a046cd 100644
--- a/libcli/security/dom_sid.c
+++ b/libcli/security/dom_sid.c
@@ -96,20 +96,12 @@ bool dom_sid_parse(const char *sidstr, struct dom_sid *ret)
 
        sidstr += 2;
 
-       if (!isdigit(sidstr[0])) {
-               return false;
-       }
-
        rev = strtoul(sidstr, &p, 10);
        if (*p != '-') {
                return false;
        }
        sidstr = p+1;
 
-       if (!isdigit(sidstr[0])) {
-               return false;
-       }
-
        ia = strtoul(sidstr, &p, 10);
        if (p == sidstr) {
                return false;
@@ -139,11 +131,6 @@ bool dom_sid_parse(const char *sidstr, struct dom_sid *ret)
                        return false;
                }
                sidstr++;
-
-               if (!isdigit(sidstr[0])) {
-                       return false;
-               }
-
                ret->sub_auths[i] = strtoul(sidstr, &p, 10);
                if (p == sidstr) {
                        return false;


-- 
Samba Shared Repository

Reply via email to