The branch, master has been updated
       via  2fff1e1... Revert "s3: remove unused Variable"
      from  e87adf5... Revert "libreplace: fix unused varibale warning on IRIX"

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master


- Log -----------------------------------------------------------------
commit 2fff1e13f1d0f450a1efc771e209a3b3f94fb7c4
Author: Jeremy Allison <[email protected]>
Date:   Mon Jan 25 17:06:54 2010 -0800

    Revert "s3: remove unused Variable"
    
    This reverts commit 9536d94d5478b63fc05047964b40d8786a7246c4.
    
    Bjorn, your change removed the ndr_decoding of the dos attribute.
    Not a good idea :-).
    
    Jeremy.

-----------------------------------------------------------------------

Summary of changes:
 source3/smbd/dosmode.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source3/smbd/dosmode.c b/source3/smbd/dosmode.c
index bc39e02..aaef09b 100644
--- a/source3/smbd/dosmode.c
+++ b/source3/smbd/dosmode.c
@@ -226,6 +226,7 @@ static bool get_ea_dos_attribute(connection_struct *conn,
                                 uint32 *pattr)
 {
        struct xattr_DOSATTRIB dosattrib;
+       enum ndr_err_code ndr_err;
        DATA_BLOB blob;
        ssize_t sizeret;
        fstring attrstr;
@@ -260,6 +261,9 @@ static bool get_ea_dos_attribute(connection_struct *conn,
        blob.data = (uint8_t *)attrstr;
        blob.length = sizeret;
 
+       ndr_err = ndr_pull_struct_blob(&blob, talloc_tos(), NULL, &dosattrib,
+                       (ndr_pull_flags_fn_t)ndr_pull_xattr_DOSATTRIB);
+
        DEBUG(10,("get_ea_dos_attribute: %s attr = %s\n",
                  smb_fname_str_dbg(smb_fname), dosattrib.attrib_hex));
 


-- 
Samba Shared Repository

Reply via email to