The branch, master has been updated
via bf7ca3f s3-spoolss: Fix _spoolss_GetPrinter().
from fc1a5db s3-spoolss: Don't leak memory on the session counter list.
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
- Log -----------------------------------------------------------------
commit bf7ca3f5e7e6f126fd8baec5548dfd45bc5e168f
Author: Günther Deschner <g...@samba.org>
Date: Fri Sep 10 16:55:23 2010 +0200
s3-spoolss: Fix _spoolss_GetPrinter().
In the error case, we need to TALLOC_FREE(r->out.info), don't ask :-)
Guenther
-----------------------------------------------------------------------
Summary of changes:
source3/rpc_server/srv_spoolss_nt.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
Changeset truncated at 500 lines:
diff --git a/source3/rpc_server/srv_spoolss_nt.c
b/source3/rpc_server/srv_spoolss_nt.c
index b5e2ddb..881f0e5 100644
--- a/source3/rpc_server/srv_spoolss_nt.c
+++ b/source3/rpc_server/srv_spoolss_nt.c
@@ -4533,7 +4533,7 @@ WERROR _spoolss_GetPrinter(struct pipes_struct *p,
lp_const_servicename(snum),
&info2);
if (!W_ERROR_IS_OK(result)) {
- return result;
+ goto out;
}
switch (r->in.level) {
@@ -4584,6 +4584,7 @@ WERROR _spoolss_GetPrinter(struct pipes_struct *p,
break;
}
+ out:
if (!W_ERROR_IS_OK(result)) {
DEBUG(0, ("_spoolss_GetPrinter: failed to construct printer
info level %d - %s\n",
r->in.level, win_errstr(result)));
--
Samba Shared Repository
