The branch, master has been updated
       via  8de2c15 s3: auth.krb5ccname and auth.unix_username are both fstrings
      from  f101349 selftest/s3-selftest.sh: knownfailure filtering for 
non-build-farm make test

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master


- Log -----------------------------------------------------------------
commit 8de2c15df32d44dfffbc3d0e9c9fd105f87c6886
Author: Volker Lendecke <[email protected]>
Date:   Fri Sep 10 12:49:32 2010 +0200

    s3: auth.krb5ccname and auth.unix_username are both fstrings
    
    There's no point in checking for != NULL

-----------------------------------------------------------------------

Summary of changes:
 nsswitch/libwbclient/wbc_pam.c |    6 ++----
 1 files changed, 2 insertions(+), 4 deletions(-)


Changeset truncated at 500 lines:

diff --git a/nsswitch/libwbclient/wbc_pam.c b/nsswitch/libwbclient/wbc_pam.c
index 50524d2..41c1142 100644
--- a/nsswitch/libwbclient/wbc_pam.c
+++ b/nsswitch/libwbclient/wbc_pam.c
@@ -313,8 +313,7 @@ static wbcErr wbc_create_logon_info(struct 
winbindd_response *resp,
        wbc_status = wbc_create_auth_info(resp, &i->info);
        BAIL_ON_WBC_ERROR(wbc_status);
 
-       if (resp->data.auth.krb5ccname &&
-           strlen(resp->data.auth.krb5ccname)) {
+       if (resp->data.auth.krb5ccname[0] != '\0') {
                wbc_status = wbcAddNamedBlob(&i->num_blobs,
                                             &i->blobs,
                                             "krb5ccname",
@@ -324,8 +323,7 @@ static wbcErr wbc_create_logon_info(struct 
winbindd_response *resp,
                BAIL_ON_WBC_ERROR(wbc_status);
        }
 
-       if (resp->data.auth.unix_username &&
-           strlen(resp->data.auth.unix_username)) {
+       if (resp->data.auth.unix_username[0] != '\0') {
                wbc_status = wbcAddNamedBlob(&i->num_blobs,
                                             &i->blobs,
                                             "unix_username",


-- 
Samba Shared Repository

Reply via email to