The branch, master has been updated
via e865788 dbwrap: Add a comment explaining a restriction
from e3f5e47 smbd: Remove an optimization that became unnecessary
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
- Log -----------------------------------------------------------------
commit e8657887a9c1deadbd4e98c8b66cd46bdf36402a
Author: Volker Lendecke <[email protected]>
Date: Wed Mar 27 10:23:50 2013 +0100
dbwrap: Add a comment explaining a restriction
Signed-off-by: Volker Lendecke <[email protected]>
Reviewed-by: Stefan Metzmacher <[email protected]>
Autobuild-User(master): Stefan Metzmacher <[email protected]>
Autobuild-Date(master): Wed Mar 27 13:40:15 CET 2013 on sn-devel-104
-----------------------------------------------------------------------
Summary of changes:
lib/dbwrap/dbwrap.c | 11 +++++++++++
1 files changed, 11 insertions(+), 0 deletions(-)
Changeset truncated at 500 lines:
diff --git a/lib/dbwrap/dbwrap.c b/lib/dbwrap/dbwrap.c
index f0b7a9a..f03514d 100644
--- a/lib/dbwrap/dbwrap.c
+++ b/lib/dbwrap/dbwrap.c
@@ -453,6 +453,17 @@ int dbwrap_get_seqnum(struct db_context *db)
int dbwrap_transaction_start(struct db_context *db)
{
if (!db->persistent) {
+ /*
+ * dbwrap_ctdb has two different data models for persistent
+ * and non-persistent databases. Transactions are supported
+ * only for the persistent databases. This check is here to
+ * prevent breakages of the cluster case, autobuild at this
+ * point only tests non-clustered Samba. Before removing this
+ * check, please make sure that this facility has also been
+ * added to dbwrap_ctdb.
+ *
+ * Thanks, vl
+ */
DEBUG(1, ("transactions not supported on non-persistent "
"database %s\n", db->name));
return -1;
--
Samba Shared Repository
